Well, generally speaking, if you keep smoking, you can get your yellow eyes. And if you have liver problems, this symptom will be more serious. When you smoke, it will make bilirubin, which is a byproduct of old red blood cells, can not be filtered by the liver as efficiently. So in this way, you have increased blood flow to the eyes, and even mild jaundice. Finally, you'll get yellow eyes. Anyway, you should give up smoking, when you have this symptom. Besides, by smoking weed, it can also lead to dark circles, eye bags and the lazy eyes. In some cases, it can lead to the long term effects, such as hearing loss, and the lung problem. And also, it can degrade the night vision. So it can be kind of dangerous. So you should be careful about it.
Smoking does not affect your eye colour, it just makes your eyes bloodshot and affects the health in a way, for example, it can cause lung problems if you are smoking too much everyday. Smoking cigarettes even can cause a drop in blood pressure, clogs your lungs overtime which slow oxygen to all parts of the body, including your eyes and brain, makes your body being sub-health condition.